Fix Tvdb Provider Episode Search #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
approved these changes
Dec 12, 2019
JustAMan
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in
TvdbEpisodeProvider.GetSearchResults()that was always preventing the search from executing.Changes
The
GetSearchResults()method checks to make sure either an episode number or premier date is included in the search parameters before submitting the request. However, the existing boolean logic was incorrect and returned an empty list if either parameter was missing. I have fixed the boolean logic to correctly check for this condition and return an empty list only if both parameters are missing.Issues
Fixes: jellyfin-archive/jellyfin-plugin-autoorganize#13