Enable TreatWarningsAsErrors for some projects #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analyzers are only run in debug build, so setting TreatWarningsAsErrors for release build will catch the compiler warnings until we resolve all analyzer warnings.
EraYaN
reviewed
Dec 17, 2019
EraYaN
reviewed
Dec 17, 2019
|
@EraYaN They are only being added to files that aren't documented 100%, this way new files are required to have full documentation. |
EraYaN
reviewed
Dec 18, 2019
EraYaN
reviewed
Dec 18, 2019
EraYaN
approved these changes
Dec 21, 2019
dkanada
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzers are only run in debug build, so setting
TreatWarningsAsErrorsfor release build will catch the compiler warnings until we resolve all
analyzer warnings.