Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jellyfin.Drawing.Skia Warnings and Analyzers #2155

Merged

Conversation

mark-monteiro
Copy link
Member

Fix existing warnings in the Jellyfin.Drawing.Skia project and enable all analyzers.

Issues
Related to #2149

@mark-monteiro mark-monteiro changed the title Jellyfin.Drawing.Skia Warnings and Analyzers Jellyfin.Drawing.Skia Warnings and Analyzers Dec 14, 2019
Copy link
Member

@Bond-009 Bond-009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for helping out with this.

Jellyfin.Drawing.Skia/SkiaEncoder.cs Outdated Show resolved Hide resolved
Copy link
Member

@Bond-009 Bond-009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Bond-009 Bond-009 merged commit 91562a4 into jellyfin:master Dec 17, 2019
@mark-monteiro mark-monteiro deleted the 2149-jellyfin-drawing-skia-warnings branch December 17, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants