-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jellyfin.Drawing.Skia Warnings and Analyzers #2155
Merged
Bond-009
merged 10 commits into
jellyfin:master
from
mark-monteiro:2149-jellyfin-drawing-skia-warnings
Dec 17, 2019
Merged
Jellyfin.Drawing.Skia Warnings and Analyzers #2155
Bond-009
merged 10 commits into
jellyfin:master
from
mark-monteiro:2149-jellyfin-drawing-skia-warnings
Dec 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-monteiro
commented
Dec 14, 2019
mark-monteiro
commented
Dec 14, 2019
Jellyfin.Drawing.Skia
Warnings and Analyzers
Bond-009
reviewed
Dec 14, 2019
Bond-009
reviewed
Dec 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for helping out with this.
…fo globally This replaces the existing [SurpressMessage] attribute
Bond-009
approved these changes
Dec 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
EraYaN
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix existing warnings in the
Jellyfin.Drawing.Skia
project and enable all analyzers.Issues
Related to #2149