Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes dockerfile building on recent linux installations #2249

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

Narfinger
Copy link

The current dockerfile in the root directory does not work on linux with systemd>=227.
It aborts with some errors about not being able to get nuget packages.

The solution is to either allow more tasks to run by systemd or disable parallel building as given in these two resources.

@dkanada dkanada requested a review from EraYaN January 10, 2020 11:34
@EraYaN
Copy link
Member

EraYaN commented Jan 10, 2020

Ooh damn, systemd never really stops disappointing...

EDIT:
The real solution is this one: sudo systemctl set-property docker.service TasksMax=infinity (replace infinity with whatever is high enough, we don't have THAT may jobs)

@dkanada
Copy link
Member

dkanada commented Jan 13, 2020

@Narfinger the issue is apparently something else entirely according to chat. The image is apparently incorrect for the ARM flavors after an upstream change.

@Narfinger
Copy link
Author

I am fine if this does not get merged but perhaps there should be some information about why the current dockerfile does not compile out of the box on modern systems. Especially because it breaks with very useless messages.

I don't understand, however, how this could break arm builds.

@dkanada
Copy link
Member

dkanada commented Jan 13, 2020

This specific issue doesn't break ARM builds. It's another issue entirely, and I think your pull request isn't related to that at all. The timing made me think you were trying to fix the nightly build issue.

Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be harmless (only slightly longer builds)...

@JustAMan JustAMan merged commit 88d66d5 into jellyfin:master Jan 16, 2020
@Narfinger Narfinger deleted the docker-fix branch January 16, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants