Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable path mapping in PlaybackInfo endpoint #2295

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

shemanaev
Copy link
Contributor

For some reason paths not mapped on that endpoint, but it will be nice to have for enabling native paths in jellyfin-mpv-shim.

Changes

Issues

@JustAMan
Copy link
Contributor

Can you explain what this PR accomplishes?

@shemanaev
Copy link
Contributor Author

Oh, sorry if it wasn't clear.
I am using "Shared network folder" options for my libraries for direct play.
/Users/yyy/Items/xxx?api_key=zzz endpoint correctly maps MediaSources[x].Path property to samba paths, but
/Items/xxx/PlaybackInfo?UserId=yyy&api_key=zzz doesn't.

Also latest version of Emby returns correct paths.

// /Users/yyy/Items/xxx?api_key=zzz
{
  ...
  "MediaSources": [
    {
      "Protocol": "File",
      "Id": "xxx",
      "Path": "\\\\media.local\\movies\\500 Days Of Summer (2009) Open Matte.mkv",
      ...
}
// /Items/xxx/PlaybackInfo?UserId=yyy&api_key=zzz
{
  "MediaSources": [
    {
      "Protocol": "File",
      "Id": "xxx",
      "Path": "/media/movies/500 Days Of Summer (2009) Open Matte.mkv"
      ...
    }
  ]
}

Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be bold and break stuff, so we can fix it later! 😆

@dkanada dkanada merged commit 4abcbc6 into jellyfin:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants