Simplify image processing by removing image enhancers #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAMan
approved these changes
Jan 22, 2020
|
In short: that first change made the removal of those 2 fields possible and simplified the way the image encoder gets created and passed to the image processor |
|
I get first change now, but why remove ImageProcessor and ImageEncoder fields?.. |
|
Both aren’t needed anymore. The image processor still has a field with the image encoder. |
anthonylavado
added
the
merge conflict
JustAMan
approved these changes
Feb 12, 2020
EraYaN
approved these changes
Feb 20, 2020
Bond-009
removed
the
merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.