Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TreatWarningsAsErrors and Nullable for test projects #2358

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Enable TreatWarningsAsErrors and Nullable for test projects #2358

merged 2 commits into from
Feb 13, 2020

Conversation

Bond-009
Copy link
Member

@dkanada dkanada requested a review from cvium February 6, 2020 12:00
@anthonylavado anthonylavado added this to In progress in Release 10.5.0 via automation Feb 12, 2020
@anthonylavado anthonylavado removed this from In progress in Release 10.5.0 Feb 12, 2020
@anthonylavado anthonylavado requested a review from a team February 12, 2020 06:59
@anthonylavado anthonylavado added this to In progress in Release 10.5.0 via automation Feb 12, 2020
JustAMan
JustAMan approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some black magic here, but looks safe enough...

@dkanada dkanada merged commit 8ee9171 into jellyfin:master Feb 13, 2020
Release 10.5.0 automation moved this from In progress to Done Feb 13, 2020
@Bond-009 Bond-009 deleted the tests branch February 13, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAMan JustAMan JustAMan approved these changes

@dkanada dkanada dkanada approved these changes

@cvium cvium Awaiting requested review from cvium

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.5.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bond-009 @JustAMan @dkanada