Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix framerate info not showing when mediasource is in H264 format. #2368

Merged
merged 4 commits into from
Feb 3, 2020
Merged

Fix framerate info not showing when mediasource is in H264 format. #2368

merged 4 commits into from
Feb 3, 2020

Conversation

nyanmisaka
Copy link
Member

Changes
Fixed an issue that when the media source is in H264 format and the frame rate info is not displayed due to missing space characters in ffmpeg log.

Fixed an issue that when the media source is in H264 format and the frame rate info is not displayed due to missing space characters in ffmpeg log.
Copy link
Member

@Bond-009 Bond-009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough as a hotfix, but this whole thing should be rewritten at some point imo.

MediaBrowser.Controller/MediaEncoding/JobLogger.cs Outdated Show resolved Hide resolved
Co-Authored-By: Bond-009 <bond.009@outlook.com>
@dkanada dkanada merged commit c1ecd88 into jellyfin:master Feb 3, 2020
@JustAMan
Copy link
Contributor

Good enough as a hotfix, but this whole thing should be rewritten at some point imo.

Yeah, we should use ffmpeg progress reporting API instead of parsing a logfile :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants