Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another baseurl related fix #2400

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Another baseurl related fix #2400

merged 1 commit into from
Feb 13, 2020

Conversation

Bond-009
Copy link
Member

Baseurl always starts with a '/' (unless it's empty)

Fixes the error from #2380 (Don't know if it fixes the issue)

@Bond-009 Bond-009 added this to In progress in Release 10.5.0 via automation Feb 12, 2020
Baseurl always starts with a '/' (unless it's empty)
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's correct, I'd rather see us normalizing a URL before processing it... because //jellyfin should be identical to /jellyfin IMHO

@Bond-009
Copy link
Member Author

What do you mean? We know for a fact the baseurl start with a '/' we make sure of that in the setter of the property

@JustAMan
Copy link
Contributor

@Bond-009 okay, here's your greenmark from me.
But still, normalizing a URL prior to processing it sounds a right thing to do... though it's probably should be done by Kestrel, not us.

@Bond-009
Copy link
Member Author

We don't process any url here, we take the hostname and create a url from that

@dkanada dkanada merged commit cf26264 into jellyfin:master Feb 13, 2020
Release 10.5.0 automation moved this from In progress to Done Feb 13, 2020
@Bond-009 Bond-009 deleted the baseurl branch February 13, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants