-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix episode parsing #2429
Fix episode parsing #2429
Conversation
Please add a season number test with the same Daily show filename. Currently JF ids that episode as 1x25 and not the correct 25x22. |
jellyfin/Emby.Naming/Common/NamingOptions.cs Lines 317 to 325 in 620047a
These expressions look like the correct ones to fix the tests. They are KODI naming standard. Maybe just the first expression I linked will match the specific test cases you've added. |
We moved that expression before the Kodi expressions because of false positives. |
Not sure if we should modify it further but I do receive false positives when the name is within the name of another movie. This is under the current regex, not this proposed regex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but I'd like to see others' questions resolved before stamping a green mark.
@Artiume Create an issue with the full filename |
Issues
Fixes #2171