Fix Playlist Deletion #2491
Merged
Fix Playlist Deletion #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-monteiro
commented
Mar 1, 2020
| if (filename.IndexOf("[playlist]", StringComparison.OrdinalIgnoreCase) != -1) | ||
| // It's a directory-based playlist if the directory contains a playlist file | ||
| var filePaths = Directory.EnumerateFiles(args.Path); | ||
| if (filePaths.Any(f => f.EndsWith(PlaylistXmlSaver.DefaultPlaylistFilename, StringComparison.OrdinalIgnoreCase))) |
There was a problem hiding this comment.
This diff is a bit messy because I also cleaned up the surrounding code, but the main change in this PR is that I added this if block
mark-monteiro
commented
Mar 1, 2020
|
|
||
| if (string.IsNullOrEmpty(filename)) | ||
| // It's a boxset if the path is a directory with [playlist] in it's the name | ||
| // TODO: Should this use Path.GetDirectoryName() instead? |
There was a problem hiding this comment.
The use of Path.GetFileName() here seems incorrect, but I just left a TODO instead of changing it in order to not expand the scope of this PR. Can remove the TODO if it would be preferred to just leave it as-is
|
I'll leave the review of the code to people who know what they're doing, but this does prevent playlists from being deleted when the scheduled task runs. It also seems to restore the existing playlists that had stopped appearing before, so double 🎉 points |
JustAMan
approved these changes
Mar 2, 2020
Bond-009
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with playlists being removed from the library during library scans.
Changes
Updated the
PlaylistResolverto correctly resolve playlist items that are stored in the library using a directory.Issues
Fixes #2425