Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ability to run migration routines when updating Jellyfin #2515

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Implement ability to run migration routines when updating Jellyfin #2515

merged 2 commits into from
Mar 5, 2020

Conversation

JustAMan
Copy link
Contributor

@JustAMan JustAMan commented Mar 5, 2020 •
edited

Changes

  • Implement running generic Jellyfin update routines.
  • Set EnableThrottling to false on pre-10.5.0 migration to 10.5.0 or newer, as this option wasn't used before and in 10.5.0 there are reports it's causing issues. Users could still enable it after installation in the admin dashboard.

Issues

Fixes #2516

@JustAMan JustAMan requested a review from a team March 5, 2020 14:44
@JustAMan JustAMan added this to In progress in Release 10.5.0 via automation Mar 5, 2020
joshuaboniface
joshuaboniface approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@joshuaboniface joshuaboniface requested a review from a team March 5, 2020 14:54
@JustAMan JustAMan requested review from a team and removed request for a team March 5, 2020 14:54
sparky8251
sparky8251 approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@sparky8251 sparky8251 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustAMan is apparently precognitive. I approve lol

@joshuaboniface joshuaboniface merged commit dcf3dbb into jellyfin:master Mar 5, 2020
Release 10.5.0 automation moved this from In progress to Done Mar 5, 2020
@JustAMan JustAMan deleted the migration-scripts branch March 5, 2020 15:31
@JustAMan JustAMan mentioned this pull request Mar 5, 2020
Merged
heyhippari added a commit to heyhippari/jellyfin that referenced this pull request Mar 7, 2020
@heyhippari
Revert "Merge pull request jellyfin#2515 from JustAMan/migration-scri…
a9ed7a8 
…pts"

This reverts commit dcf3dbb, reversing
changes made to ca585f1.
heyhippari added a commit to heyhippari/jellyfin that referenced this pull request Mar 7, 2020
@heyhippari
Revert "Merge pull request jellyfin#2515 from JustAMan/migration-scri…
c27e746 
…pts"

This reverts commit dcf3dbb, reversing
changes made to ca585f1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-monteiro mark-monteiro mark-monteiro left review comments

@joshuaboniface joshuaboniface joshuaboniface approved these changes

@dkanada dkanada dkanada left review comments

@sparky8251 sparky8251 sparky8251 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.5.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement configuration file versioning
5 participants
@JustAMan @sparky8251 @mark-monteiro @joshuaboniface @dkanada