-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Logging Configuration Heirarchy #2535
Create Logging Configuration Heirarchy #2535
Conversation
Jellyfin.Server/Migrations/Routines/CreateUserLoggingConfigFile.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trusting that this all works 🤞
Jellyfin.Server/Migrations/Routines/CreateUserLoggingConfigFile.cs
Outdated
Show resolved
Hide resolved
Also save migration configuration after each migration instead of at the end in case an exception is thrown part way through the list
Also use a list instead of an array to store executed migrations in the configuration class
Okay, pushed some more updates:
|
…st with development/debugging
Pushed one more change to store the migration name alongside the id in the config file's list of applied migrations. Only the Guid is used to uniquely identify the migration in the runner, but the name is added to assist with development/debugging |
Why did this functionality get added to Jellyfin.Server? imo it should be added to Emby.Server.Implementations. |
What's the difference between these two projects? I'm not super familiar with the project layout yet.
Why not? Where would be an appropriate place to put it? |
Jellyfin.Server is for platform specific code, things that require netcoreapp and setup. Emby.Server.Implementations is everything else we need and can use in xamarin for example without modifications. Following the xdg spec:
Ref: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html Afaik it’s fine on windows as is |
Separate logging configuration into
logging.default.json
andlogging.user.json
so that we can updatelogging.default.json
at will in the future and allow users to manage their ownlogging.user.json
file which overwrites the defaults.Changes
logging.json
tologging.default.json
. The deprecatedlogging.json
file will be left in place.logging.user.json
file. If the user has made modifications tologging.json
, that is used to initialize the new file. Otherwise it is initialized with empty content.logging.default.json
andlogging.user.json
(the user config file is optional)Issues
Fixes #2511