New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some warnings #2741
Fix some warnings #2741
Conversation
var types = new[] | ||
{ | ||
PersonType.Director, | ||
PersonType.Writer, | ||
PersonType.Producer, | ||
PersonType.Composer, | ||
"Creator" | ||
"creator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why it's not a PersonType.Creator
?..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot we create one?
Co-Authored-By: Vasily <JustAMan@users.noreply.github.com>
Co-Authored-By: Mark Monteiro <marknr.monteiro@protonmail.com>
Also adds the
AddPeople
method back inDidlBuilder
, it was commented out in the .net core port