Fix DLNA clients displaying wrong album art. #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaboniface
approved these changes
Apr 19, 2020
dkanada
approved these changes
Apr 20, 2020
joshuaboniface
pushed a commit
that referenced
this pull request
Apr 26, 2020
Fix DLNA clients displaying wrong album art. (cherry picked from commit 1cc5d67) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where DLNA clients (VLC, Foobar) display incorrect album art for some music albums. Specifically albums that don't have folder/cover image file (i.e. a folder of mp3's) "steal" cover image from a different album, typically whichever appears first in the list.
For example, in the below folder structure, the first folder contains a folder.jpg file, but second doesn't. When viewed in VLC both albums show the image from the first folder.
Music/jazz
├── Bill Evans - Bill Evans Trio with Symphony Orchestra
│ ├── 01 - Granadas.flac
│ ├── 02 - Valse.flac
│ └── folder.jpg
└── David Chesky - Jazz In The New Harmonic
├── 01-Jazz in the New Harmonic.flac
└── 08-Transcendental Tripping.flac