Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved tests #2917

Merged
merged 4 commits into from Apr 29, 2020
Merged

Improved tests #2917

merged 4 commits into from Apr 29, 2020

Conversation

Bond-009
Copy link
Member

Covers more branches and should be faster

mark-monteiro
mark-monteiro reviewed Apr 19, 2020
View reviewed changes
Emby.Naming/Audio/AlbumParser.cs Outdated Show resolved Hide resolved
Emby.Naming/Subtitles/SubtitleParser.cs Outdated Show resolved Hide resolved
tests/Jellyfin.Naming.Tests/Music/MultiDiscAlbumTests.cs Outdated Show resolved Hide resolved
tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs Outdated Show resolved Hide resolved
mark-monteiro
mark-monteiro reviewed Apr 19, 2020
View reviewed changes
Copy link
Member

@mark-monteiro mark-monteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions on the test names. That's just how I have personally done test naming in the past, so definitely open to discussion on those

tests/Jellyfin.Model.Tests/Extensions/StringHelperTests.cs Outdated Show resolved Hide resolved
tests/Jellyfin.Naming.Tests/Music/MultiDiscAlbumTests.cs Show resolved Hide resolved
tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs Outdated Show resolved Hide resolved
tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs Outdated Show resolved Hide resolved
tests/Jellyfin.Naming.Tests/Subtitles/SubtitleParserTests.cs Outdated Show resolved Hide resolved
@Bond-009 Bond-009 requested review from mark-monteiro and a team April 20, 2020 07:53
mark-monteiro
mark-monteiro approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@mark-monteiro mark-monteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple minor outstanding suggestions regarding naming, but none of them are super important. LGTM.

tests/Jellyfin.Model.Tests/Extensions/StringHelperTests.cs Outdated Show resolved Hide resolved
@JustAMan JustAMan merged commit aff65ad into jellyfin:master Apr 29, 2020
@Bond-009 Bond-009 deleted the tests branch August 20, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAMan JustAMan JustAMan approved these changes

@mark-monteiro mark-monteiro mark-monteiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bond-009 @JustAMan @mark-monteiro