Fix a few issues with the plugin manifest

[dkanada]

This removes the last of the annoying properties from the version and package info classes. The installation is now used internally to collect data from both classes, but at some point we could also start using a tuple instead.

[dkanada]

@mark-monteiro this should resolve the issue in #2951 by reverting the version to a string in the serialization object and parsing it as a version for the class that gets passed around for the install.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
6 Code Smells

0.0% Coverage
0.0% Duplication

[mark-monteiro]

In general this looks fine but I couldn't test because the web UI for installing plugins is broken. Is there a web PR that needs to go along with this?

Selecting one of the 'undefined' options and clicking install fails and gives this error in the console:

Error: null updateClass apiClient.js:1368:18

[dkanada]

Looks like I'll have to do another pass through web as well, this was mainly to remove the last few duplicate properties and fix the serialization issues.

[mark-monteiro]

Looks like I'll have to do another pass through web as well, this was mainly to remove the last few duplicate properties and fix the serialization issues.

Yeah, the errors in the web client did not appear to be related to this PR. But it would be nice to have the web side working to test this.

[Artiume]

general this looks fine but I couldn't test because the web UI for installing plugins is broken. Is there a web PR that needs to go along with this?

@barronpm and I saw a similar issue in the User DB migrations for User Authentication

[barronpm]

The cause of the error @Artiume mentioned was accidentally adding the same assembly to the Enumerable returned by ApplicationHost.GetComposablePartAssemblies, but this doesn't look the same, as all of the options are "undefined" for you

[mark-monteiro]

I believe the issue I had was fixed here: https://github.com/jellyfin/jellyfin-web/pull/1291/files
Just need to find some time to come back to this to test it again

[dkanada]

@mark-monteiro there's still one more PR to merge in web updating the API client before this should be working again.

EDIT: That PR was merged and this should ideally be working now.

[dkanada]

Versions seem to be fine, but the installation is failing due to changes from the API client migration.

[crobibero]

Looks like InstallationInfo.SourceUrl needs to be set in Emby.Server.Implementations\Updates\InstallationManager.cs L220

[crobibero]

Publish failing due to following errors:

EntryPoints/ServerEventNotifier.cs(91,13): error CS4014: Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call. [/home/vsts/work/1/s/Emby.Server.Implementations/Emby.Server.Implementations.csproj]
EntryPoints/ServerEventNotifier.cs(89,28): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/vsts/work/1/s/Emby.Server.Implementations/Emby.Server.Implementations.csproj]
EntryPoints/ServerEventNotifier.cs(96,13): error CS4014: Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call. [/home/vsts/work/1/s/Emby.Server.Implementations/Emby.Server.Implementations.csproj]
EntryPoints/ServerEventNotifier.cs(94,28): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/vsts/work/1/s/Emby.Server.Implementations/Emby.Server.Implementations.csproj]
EntryPoints/ServerEventNotifier.cs(101,13): error CS4014: Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call. [/home/vsts/work/1/s/Emby.Server.Implementations/Emby.Server.Implementations.csproj]
EntryPoints/ServerEventNotifier.cs(99,28): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/vsts/work/1/s/Emby.Server.Implementations/Emby.Server.Implementations.csproj]
EntryPoints/ServerEventNotifier.cs(121,13): error CS4014: Because this call is not awaited, execution of the current method continues before the call is completed. Consider applying the 'await' operator to the result of the call. [/home/vsts/work/1/s/Emby.Server.Implementations/Emby.Server.Implementations.csproj]
EntryPoints/ServerEventNotifier.cs(119,28): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/home/vsts/work/1/s/Emby.Server.Implementations/Emby.Server.Implementations.csproj]

[dkanada]

I see you've been enabling more errors 😆 I'll fix them now.