Replace links to emby.media #32
Conversation
- updates ManufacturerUrl and ModelUrl to jellyfin repo
- restores the original URL for some comments, keeping context
| @@ -2,11 +2,11 @@ | |||
| <Profile xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | |||
| <Name>Generic Device</Name> | |||
| <Manufacturer>Emby</Manufacturer> | |||
| <ManufacturerUrl>https://emby.media</ManufacturerUrl> | |||
| <ManufacturerUrl>https://github.com/jellyfin/jellyfin</ManufacturerUrl> | |||
There was a problem hiding this comment.
I thought we had a site named "jellyfin.media", maybe change to it instead of direct link to repo?
There was a problem hiding this comment.
Agreed here, let's use jellyfin.media wherever possible.
| @@ -82,7 +82,7 @@ private async Task DownloadNews(string path) | |||
|
|
|||
| var requestOptions = new HttpRequestOptions | |||
| { | |||
| Url = "https://emby.media/community/index.php?/blog/rss/1-media-browser-developers-blog", | |||
| Url = "https://github.com/jellyfin/jellyfin", | |||
There was a problem hiding this comment.
I think this place warrants a //TODO: add proper rss feed comment or something similar
| @@ -45,14 +45,14 @@ <h2 class="sectionTitle">${HeaderInstall}</h2> | |||
|
|
|||
| <p>${MessagePluginRequiresSubscription}</p> | |||
|
|
|||
| <p><a is="emby-linkbutton" class="button-link" href="https://emby.media/premiere" target="_blank">${LinkLearnMoreAboutSubscription}</a></p> | |||
| <p><a is="emby-linkbutton" class="button-link" href="https://github.com/jellyfin/jellyfin" target="_blank">${LinkLearnMoreAboutSubscription}</a></p> | |||
There was a problem hiding this comment.
Shouldn't this be removed completely? There is not going to be any subscription to Jellyfin, right?
|
|
||
| </div> | ||
| <div class="premiumDescription"> | ||
|
|
||
| <p>${MessagePremiumPluginRequiresMembership}</p> | ||
|
|
||
| <p><a is="emby-linkbutton" class="button-link" href="https://emby.media/premiere" target="_blank">${LinkLearnMoreAboutSubscription}</a></p> | ||
| <p><a is="emby-linkbutton" class="button-link" href="https://github.com/jellyfin/jellyfin" target="_blank">${LinkLearnMoreAboutSubscription}</a></p> |
| @@ -6,7 +6,7 @@ define(["globalize", "shell", "browser", "apphost"], function(globalize, shell, | |||
| } | |||
|
|
|||
| function getPremiumInfoUrl() { | |||
| return "https://emby.media/premiere" | |||
| return "https://github.com/jellyfin/jellyfin" | |||
There was a problem hiding this comment.
shouldn't we remove this?
|
@JustAMan Yes, the links should be removed completely, but I know @joshuaboniface had a world of trouble already trying to make changes to the HTML. The layout... is fragile. I’ve made a new issue for that, #15. |
|
@anthonylavado Thanks! |
This helps close #23.
Replaced all the links to emby.media with ones that point to the repo's page instead.
I broke this in to two commits. First, 3ad80d1 updates all the DLNA profiles. This should present no issues to anyone.
Second, 00627eb updates the URL in a lot of other web pages, especially in frontend templates. While this should be okay, the News Feed functionality will not load any articles, and the connect/premiere links won't do much at this point. Perhaps it's a note to remove/close those functions off in a separate issue.