Prevent system plugins from being uninstalled #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAMan
suggested changes
Jun 22, 2020
Co-authored-by: Vasily <JustAMan@users.noreply.github.com>
JustAMan
approved these changes
Jun 22, 2020
crobibero
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added
CanUninstallproperty to Plugin to indicate whether a plugin can be uninstalled. If an attempt is made to uninstall a plugin with this property set toFalse, it is logged and the uninstallation does not proceed.Current
CanUninstallis simply a check if the Plugin Assembly path is the same as the main Jellyfin path. This could can be changed in the future to add additional/different logic if required.Related Web PR: jellyfin/jellyfin-web#1464
Issues
Fixes #2555