Minor fixes to ActivityManager #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
approved these changes
Aug 1, 2020
cvium
reviewed
Aug 1, 2020
| @@ -40,8 +40,9 @@ public void Create(ActivityLog entry) | |||
| /// <inheritdoc/> | |||
| public async Task CreateAsync(ActivityLog entry) | |||
| { | |||
| using var dbContext = _provider.CreateContext(); | |||
| await dbContext.ActivityLogs.AddAsync(entry); | |||
| await using var dbContext = _provider.CreateContext(); | |||
There was a problem hiding this comment.
@Bond-009 What about ConfigureAwait here?
There was a problem hiding this comment.
Good point.
Should be done like this:
var dbContext = _provider.CreateContext();
await using dbContext.ConfigureAwait(false);There was a problem hiding this comment.
crobibero
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Uses synchronous Add() and asynchronous context creation.