Allow plugins to define their own api endpoints #3871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daullmer
changed the title
This was referenced Aug 12, 2020
crobibero
reviewed
Aug 14, 2020
crobibero
approved these changes
Aug 14, 2020
cvium
reviewed
Aug 31, 2020
cvium
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To allow plugins to register their own ASP.NET Web Api endpoints, we need to register each assembly in the
MvcBuilder.However, this is currently not possible, asapplicationHost.Pluginsdoesn't contain the plugins. They get loaded afterStartup.ConfigureServicesran.Can we load the plugins earlier? I tried to move some things around (calling this line before calling this line) but
InitializeServicesneeds theappHost.ServiceProviderwhich we get from the WebHostBuilder.