Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Unstable NuGet packages #3889

Merged
merged 5 commits into from Aug 25, 2020

Conversation

daullmer
Copy link
Member

@daullmer daullmer commented Aug 13, 2020

Changes
With this PR merged, every commit to master builds unstable nuget packages. They don't get pushed to any Nuget feeds. To achive this, I added the VersionPrefix property to every .csproj file which outputs Nuget packages and integrated the version number into the bump_version script.

I changed the Nuget pack CI task to the .Net Core pack Task because of this note in the docs

Please note that DotNetCore and DotNetStandard packages should be packaged with the DotNetCoreCLI@2 task to avoid System.InvalidCastExceptions. See the .NET Core CLI task for more details.

Issues
This allows for easier plugin development before we publish the stable version because we can make changes to the plugins during the release cycle.

@daullmer daullmer changed the title Fix nuget package creation in CI Build Unstable NuGet packages Aug 13, 2020
bump_version Outdated Show resolved Hide resolved
bump_version Outdated Show resolved Hide resolved
Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it all works as intended, it looks good to me, but I'll hold off on merging for feedback on my comments.

@joshuaboniface joshuaboniface merged commit e83f6d6 into jellyfin:master Aug 25, 2020
@daullmer daullmer deleted the nuget-versioning branch August 31, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants