Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullable for MediaBrowser.Providers project #4929

Closed

Conversation

martinek-stepan
Copy link
Contributor

Changes

Enable nullable on the project level and reflect changes in code.

Issues

Part of issue #2768

Stepan added 3 commits January 2, 2021 16:00
Signed-off-by: Stepan <ste.martinek+git@gmail.com>
Signed-off-by: Stepan <ste.martinek+git@gmail.com>
@daullmer
Copy link
Member

daullmer commented Feb 8, 2021

We are currently removing the metadata providers from jellyfin/jellyfin into seperate repositories (see #4530 #4531 #4532). But we still need a method of installing them during the initial setup. That's why the PRs are not merged. The new plugins already have nullable enabled (https://github.com/jellyfin/jellyfin-plugin-omdb, https://github.com/jellyfin/jellyfin-plugin-tmdb, https://github.com/jellyfin/jellyfin-plugin-musicbrainz). I think we should wait merging this PR till the providers are removed, if that's okay for you

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Apr 14, 2021
@stale
Copy link

stale bot commented Aug 18, 2021

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale Stale and will be closed if no activity occurs label Aug 18, 2021
@1337joe
Copy link
Member

1337joe commented Nov 11, 2021

Original issue (#2768) fixed by #6737, closing this as OBE

@1337joe 1337joe closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Merge conflicts should be resolved before a merge stale Stale and will be closed if no activity occurs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants