Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux-arm and linux-arm64 native NuGet dependency. #534

Merged
merged 5 commits into from Jan 19, 2019
Merged

Add linux-arm and linux-arm64 native NuGet dependency. #534

merged 5 commits into from Jan 19, 2019

Conversation

EraYaN
Copy link
Member

@EraYaN EraYaN commented Jan 9, 2019

Build scripts are here: https://github.com/jellyfin/jellyfin-skiasharp-native

To test after building and packing

  1. cd Emby.Drawing.Skia
  2. dotnet add package Jellyfin.SkiaSharp.NativeAssets.LinuxArm -s ..\..\jellyfin-skiasharp-native\Jellyfin.SkiaSharp.NativeAssets.LinuxArm
  3. dotnet add package Jellyfin.SkiaSharp.NativeAssets.LinuxMusl -s ..\..\jellyfin-skiasharp-native\Jellyfin.SkiaSharp.NativeAssets.LinuxMusl

-s specifies the source.

Let's drop Musl for now, dotnet is clearly not ready yet. Even icu-libs on alpine pull in libstdc++.

@EraYaN
Copy link
Member Author

EraYaN commented Jan 10, 2019

Uploaded: https://www.nuget.org/packages/EraYaN.SkiaSharp.NativeAssets.LinuxArm/1.68.0 So drone build should succeed next time.

@joshuaboniface joshuaboniface added backend Related to the server backend build Issues with the build process labels Jan 11, 2019
@JustAMan
Copy link
Contributor

I've kicked new Drone task.

@jellyfin/core do you guys think we need to publish this SkiaSharp under Jellyfin nuget acc?

@EraYaN
Copy link
Member Author

EraYaN commented Jan 12, 2019

New build targets arm64 in GN instead of aarch64. Now it doesn't have *UND* symbols. It now loads in debian aarch64 on qemu. Drone might fail since package publish might take an hour.

EDIT: also works on a Odroid C2. (S905 based board)

@JuliusFreudenberger
Copy link

I tested a build from @EraYaN on my Odroid C2, which is aarch64. I ran DietPi as OS, which is basically Debian 9 for arm architectures.
It worked and didn't log any error regarding Skia.

@Bond-009 Bond-009 added this to Reviewer approved in Release 10.1.0 Jan 16, 2019
@Bond-009 Bond-009 moved this from Reviewer approved to Needs review in Release 10.1.0 Jan 16, 2019
@EraYaN EraYaN changed the title Add linux-arm and linux-arm64 native NuGet dependency. Add linux-musl-x64, linux-arm and linux-arm64 native NuGet dependency. Jan 16, 2019
Release 10.1.0 automation moved this from Needs review to Reviewer approved Jan 16, 2019
@nvllsvm
Copy link
Member

nvllsvm commented Jan 16, 2019

Just a question - which package are the Musl ARM libs included in?

@EraYaN
Copy link
Member Author

EraYaN commented Jan 16, 2019

@nvllsvm These are not uploaded yet and will break the build.

There is no musl+arm combination, since there is also no sqlite for that platform. I also don't think there is dotnet core support.

@EraYaN
Copy link
Member Author

EraYaN commented Jan 16, 2019

Alright the musl one will need some extra work, it does not load now. And .NET does not seem to have actual musl support, even though the docs talk about it. Put this on hold until tomorrow or even the weekend or something.

@EraYaN EraYaN changed the title Add linux-musl-x64, linux-arm and linux-arm64 native NuGet dependency. Add linux-arm and linux-arm64 native NuGet dependency. Jan 17, 2019
@JustAMan JustAMan merged commit 85c798d into jellyfin:dev Jan 19, 2019
Release 10.1.0 automation moved this from Reviewer approved to Done Jan 19, 2019
@EraYaN EraYaN deleted the skia-native-arm branch January 20, 2019 12:18
@joshuaboniface joshuaboniface mentioned this pull request Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the server backend build Issues with the build process
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants