revert underscore as a multiversion separator #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
Mar 15, 2021
barronpm
approved these changes
Mar 16, 2021
Bond-009
approved these changes
Mar 16, 2021
joshuaboniface
pushed a commit
that referenced
this pull request
Mar 21, 2021
(cherry picked from commit f42cee4) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Looking at the history of the multi-version eligibility check and accompanying unit tests, it seems that underscore was broken/unsupported for a long time and also missing in all documentation. It seems only fair to revert this particular change as it causes some false positives and I don't see any reason to reserve three different naming schemes.
Issues
Fixes #5528