Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Clean up: "value assigned is not used in any execution path" #5836

Merged
merged 8 commits into from
Dec 24, 2021
Merged

Code Clean up: "value assigned is not used in any execution path" #5836

merged 8 commits into from
Dec 24, 2021

Conversation

BaronGreenback
Copy link
Contributor

@BaronGreenback BaronGreenback commented Apr 17, 2021 •
edited
Loading

Identified by ReSharper. Removed all unneccessary "value assigned is not used in any execution path".

daullmer
daullmer requested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@daullmer daullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like the commented out code. I would prefer if they were removed or explained why they are commented out.

@BaronGreenback
Copy link
Contributor Author

Don't like the commented out code. I would prefer if they were removed or explained why they are commented out.

Don't like the commented out code. I would prefer if they were removed or explained why they are commented out.

Removed.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label May 5, 2021
@jellyfin-bot jellyfin-bot added merge conflict Merge conflicts should be resolved before a merge and removed merge conflict Merge conflicts should be resolved before a merge labels May 5, 2021
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label May 8, 2021
@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label May 21, 2021
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Jun 19, 2021
@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Jul 23, 2021
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Dec 24, 2021
@crobibero crobibero merged commit 599fc9e into jellyfin:master Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daullmer daullmer daullmer approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BaronGreenback @daullmer @crobibero @jellyfin-bot