Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvrage and imdb ids for episodes #5881

Merged
merged 2 commits into from Apr 21, 2021

Conversation

cvium
Copy link
Member

@cvium cvium commented Apr 21, 2021

When I rewrote tmdb providers I probably forgot about the external links on the episode page...

Issues
Fixes #5869

@cvium cvium added the stable backport Backport into the next stable release label Apr 21, 2021
@cvium cvium added this to Active PRs in Release 10.7.0 via automation Apr 21, 2021
@Bond-009 Bond-009 merged commit e19d89b into jellyfin:master Apr 21, 2021
Release 10.7.0 automation moved this from Active PRs to Completed PRs Apr 21, 2021
@SenorSmartyPants
Copy link
Contributor

Please also set TMDBId, which TMDB does not consider external, but JF would.

Something like this.

            if (!string.IsNullOrEmpty(episodeResult.Id))
            {
                item.SetProviderId(MetadataProvider.Tmdb, episodeResult.Id);
            }

joshuaboniface pushed a commit to joshuaboniface/jellyfin that referenced this pull request Apr 22, 2021
Add tvrage and imdb ids for episodes

(cherry picked from commit e19d89b)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Apr 22, 2021
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Development

Successfully merging this pull request may close these issues.

TMDB Episode provider is not saving External IDs other than TVDB
5 participants