New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAPI workflow #6308
Add OpenAPI workflow #6308
Conversation
I'm marking the PR as ready now since it does work, the "to do" list contains 2 items that should be considered before merging though. |
The However, for extra peace of mind, why not run this on master commits? |
We need the openapi.json file for both the PR branch and the target (=master) branch to compare. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
bdb61e9
to
63eeb73
Compare
Changes
Add a new workflow called that does the following things:
<details>
element to prevent skyscraper tall commentsThe comments will help reviewers to determine if a PR contains breaking API changes, which might not be easy to notice in the code reviews.
To do
Some work left for this PR that I need some help with:
pull_request_target
instead ofpull_request
BUT this would allow a malicious actor to expose secrets by making changes to the .NET code. No idea how to fix.Issues
Example
See my personal fork for an example of this workflow: nielsvanvelzen#91
Issues