Add Tests, Fix metadata refresh deletes backgrounds #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix failing test: Invalid background images not purged by validate Fixes jellyfin#6310: Background images only delete when using "Replace existing images" when new image(s) is found to replace them
1337joe
commented
Nov 1, 2021
Comment on lines
+677
to
+681
| // Create a class that implements IHasScreenshots for testing since no BaseItem class is also IHasScreenshots | ||
| private class MovieWithScreenshots : Movie, IHasScreenshots | ||
| { | ||
| // No contents | ||
| } |
There was a problem hiding this comment.
This is now the only class in my workspace that is a BaseItem that implements IHasScreenshots.
Assuming it's not used in some other plugin that I don't have checked out, should either the handling for IHasScreenshots be removed or the interface itself be removed as unused?
There was a problem hiding this comment.
I wouldn't remove the interface, we never know if there is a plugin that implements it.
There was a problem hiding this comment.
I'm fine with removing it, AFAIK it was only used by the Game item type https://github.com/MediaBrowser/Emby.Common/blob/6ef8705ed609666555894c698dfc140fd8314831/MediaBrowser.Controller/Entities/Game.cs#L12
1337joe
force-pushed
the
fix-metadata-refresh-deletes-backgrounds
branch
from
a97b48b
to
b478b11
Compare
jellyfin-bot
added
the
merge conflict
…h-deletes-backgrounds
jellyfin-bot
removed
the
merge conflict
cvium
reviewed
Nov 1, 2021
cvium
reviewed
Nov 1, 2021
cvium
reviewed
Nov 2, 2021
tests/Jellyfin.Providers.Tests/Manager/ItemImageProviderTests.cs
Outdated
Show resolved
Hide resolved
cvium
approved these changes
Nov 2, 2021
crobibero
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ItemImageProviderBaseItem.ValidateImagesmethod up front instead of validating images piecemeal throughout the add/update handling.Issues
Fixes #6310