Make tags import from TMDB configurable #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new settings added
crobibero
approved these changes
Nov 2, 2021
cvium
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new settings to disable tags import from TMDB for Movies and Series. Most tags are only available in English, so other languages should be able to disable the import. I don't like the naming of most tags, so I would disable them even with English as language.
Changes
Settings have "Exclude" in their name, so default behaviour without a configuration change is to import the tags (act as before)
Issues
https://github.com/jellyfin/jellyfin-plugin-tmdb/issues/10
Hint
Don't test the same movie/serie again after a configuration change. Providers use an IMemoryCache and if a movie/serie/person/... is in cache, the refresh doesn't trigger a new search, it uses the data from cache. A configuration change for some (all?) settings should clear the cache imho (only a language change is safe, the language is part of the key from cache), but that's a problem for all providers and not part of this PR.