Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't throw exception on unauthenticated requests #6837

Merged
merged 1 commit into from Nov 13, 2021
Merged

Don't throw exception on unauthenticated requests #6837

merged 1 commit into from Nov 13, 2021

Conversation

crobibero
Copy link
Member

Fixes #6832

@joshuaboniface joshuaboniface requested a review from a team November 13, 2021 18:28
@joshuaboniface
Copy link
Member

One Q: Will this still allow this endpoint to return if there's no auth, or will it start enforcing auth here?

@crobibero
Copy link
Member Author

One Q: Will this still allow this endpoint to return if there's no auth, or will it start enforcing auth here?

Endpoints that don’t require auth work as intended with this change

@joshuaboniface joshuaboniface merged commit 761a4e8 into jellyfin:master Nov 13, 2021
@crobibero crobibero deleted the auth-exception branch November 15, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvium cvium cvium approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Health endpoint returns authentication error, spams logs
3 participants
@crobibero @joshuaboniface @cvium