Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some StyleCop warnings #686

Merged
merged 6 commits into from Jan 24, 2019
Merged

Conversation

Bond-009
Copy link
Member

Ex: warning SA1101: Prefix local calls with this

@joshuaboniface joshuaboniface changed the title Disable warning for calling local function without this. prefixed Disable warning for calling local function without this. prefixed Jan 23, 2019
jellyfin.ruleset Show resolved Hide resolved
jellyfin.ruleset Outdated Show resolved Hide resolved
@Bond-009 Bond-009 changed the title Disable warning for calling local function without this. prefixed Disable some StyleCop warnings Jan 23, 2019
jellyfin.ruleset Outdated Show resolved Hide resolved
Co-Authored-By: Bond-009 <bond.009@outlook.com>
Copy link
Member

@EraYaN EraYaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This will silence some of those "unfixable" errors, due to the busy work required to fix them.

@Bond-009
Copy link
Member Author

@EraYaN I removed them because they don't fit with our existing/future code style. Not because it would be much work to fix them. ;)

@joshuaboniface joshuaboniface merged commit a6301a1 into jellyfin:dev Jan 24, 2019
@Bond-009 Bond-009 deleted the analyzers branch January 24, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants