Only force scheme and port when HTTPS is disallowed #6871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1337joe
approved these changes
Nov 19, 2021
|
👍 I have confirmed this fixes the issue I was having with streaming from a HDHR tuner. |
crobibero
approved these changes
Nov 19, 2021
Bond-009
reviewed
Nov 19, 2021
Comment on lines
+1135
to
+1136
| var scheme = !allowHttps ? Uri.UriSchemeHttp : null; | ||
| int? port = !allowHttps ? HttpPort : null; |
There was a problem hiding this comment.
IMO, the negation should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It shouldn't force a scheme and/or port when https is allowed. The call to
GetLocalApiUrlwill decide that.