Add an option for dropping specific subtitle formats using the DLNA SubtitleProfile #6920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
reviewed
Dec 9, 2021
marius-luca-87
force-pushed
the
subtitle_drop
branch
from
9449f10
to
7d86ef6
Compare
IDisposable
approved these changes
Dec 9, 2021
crobibero
approved these changes
Dec 11, 2021
1337joe
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no option to stop DLNA from transcoding when encountering specific subtitle formats.
A new Drop option was added to the SubtitleProfile that should allow us to control when we want avoid transcoding.
For the end user it should be easier to ignore embedded PGSSUB subtitles from the DLNA profile and provide an external subtitle than to modify large video files.