Add tests for ProbeResultNormalizer.GetFrameRate #6978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
commented
Dec 12, 2021
| } | ||
|
|
||
| return float.IsNaN(result) ? null : result; | ||
| return divisor == 0f ? 0f : dividend / divisor; |
There was a problem hiding this comment.
Yes, it's fine to compare directly with 0 here,
it isn't the result of a calculation or something and I only care about exactly 0.
Bond-009
commented
Dec 12, 2021
tests/Jellyfin.MediaEncoding.Tests/Probing/ProbeResultNormalizerTests.cs
Outdated
Show resolved
Hide resolved
crobibero
approved these changes
Dec 12, 2021
1337joe
approved these changes
Dec 14, 2021
cvium
reviewed
Dec 15, 2021
|
No changes to OpenAPI specification found. See history of this comment for previous changes. |
cvium
approved these changes
Dec 18, 2021
1337joe
approved these changes
Dec 18, 2021
crobibero
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.