Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BaseItemKind where possible #6979

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Conversation

crobibero
Copy link
Member

Got a little big...

@github-actions
Copy link

Changes in OpenAPI specification found. Expand to see details.

What's Changed


POST /Sessions/{sessionId}/Viewing
Parameters:

Changed: itemType in query

The type of item to browse to.

GET /Users/{userId}/Suggestions
Parameters:

Changed: type in query

The type.

@crobibero crobibero force-pushed the baseitemkind branch 3 times, most recently from 36a817a to 1da1a02 Compare December 12, 2021 03:31
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes look fine!

tests/Jellyfin.Api.Tests/Helpers/RequestHelpersTests.cs Outdated Show resolved Hide resolved
@cvium cvium merged commit 4c9bd90 into jellyfin:master Dec 15, 2021
@1337joe
Copy link
Member

1337joe commented Dec 15, 2021

Doing this on insert:

saveItemStatement.TryBind("@type", type.FullName);

is incompatible with doing this on query (when includeTypes contains BaseItemKind):

statement?.TryBind("@type", includeTypes[0].ToString());

Will also need some migration work to convert existing installs to use BaseItemKind as the database type.

@crobibero crobibero deleted the baseitemkind branch December 16, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants