Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate LibraryOptions.EnableInternetProviders #7005

Merged
merged 1 commit into from Dec 16, 2021

Conversation

1337joe
Copy link
Member

@1337joe 1337joe commented Dec 15, 2021

Changes
Deprecate LibraryOptions.EnableInternetProviders

Rationale

  1. This is hardcoded to true without exposing to user in library options page (web) so even if you change it in the settings file manually it will be overridden when you next modify the library settings through the interface.
  2. Not evaluated unless the library options don't configure providers for a type, but the only types that aren't configured by the library options don't actually tree up to a library to find this setting (People, Trailers, etc)
  3. Currently disables IDynamicImageProvider (extracted from video file) as well as IRemoteImageProvider (fetched from internet), which is not what's implied by the name.

Long story short, disabling remote providers in a library is better done by simply unchecking the boxes for them in the library options panel.

@github-actions
Copy link

Changes in OpenAPI specification found. Expand to see details.

What's Changed


GET /Library/VirtualFolders
Return Type:

Changed response : 200 OK

Virtual folders retrieved.

  • Changed content type : application/json

Changed items (object):

Used to hold information about a user's list of configured virtual folders.

openapi-base openapi-changes.md openapi-head Changed property LibraryOptions (object)

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

  • Changed content type : application/json; profile="CamelCase"

Changed items (object):

Used to hold information about a user's list of configured virtual folders.

openapi-base openapi-changes.md openapi-head Changed property LibraryOptions (object)

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

  • Changed content type : application/json; profile="PascalCase"

Changed items (object):

Used to hold information about a user's list of configured virtual folders.

openapi-base openapi-changes.md openapi-head Changed property LibraryOptions (object)

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

POST /Library/VirtualFolders
Request:

Changed content type : application/json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

Changed content type : text/json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

Changed content type : application/*+json

Updated AddVirtualFolderDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

POST /Library/VirtualFolders/LibraryOptions
Request:

Changed content type : application/json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

Changed content type : text/json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

Changed content type : application/*+json

Updated UpdateLibraryOptionsDto :

  • Changed property LibraryOptions (object)

Gets or sets library options.

Updated LibraryOptions :
openapi-base openapi-changes.md openapi-head Changed property EnableInternetProviders (boolean)

@Bond-009 Bond-009 merged commit 16bf4a0 into jellyfin:master Dec 16, 2021
@1337joe 1337joe deleted the deprecate-enableinternetproviders branch December 16, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants