Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hearing impaired subtitle stream indicator #7379

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Add hearing impaired subtitle stream indicator #7379

merged 3 commits into from
Oct 7, 2022

Conversation

1337joe
Copy link
Member

@1337joe 1337joe commented Feb 28, 2022 •
edited

This is my first time touching the database contents, definitely let me know if anything there looks questionable.

Changes

  • Add a flag to media stream to indicate the stream is for hearing impaired users
    • Flag source: ffprobe hearing_impaired disposition, "sdh"/"hi"/"cc" in external stream file name
    • Flag use: Add localized "Hearing Impaired" indicator when selecting subtitle stream

Issues
Fixes #4291

@joshuaboniface joshuaboniface added this to Active PRs in Release 10.8.0 via automation Mar 10, 2022
@1337joe 1337joe mentioned this pull request Mar 10, 2022
Merged
@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Mar 11, 2022
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Mar 11, 2022
@joshuaboniface joshuaboniface requested a review from a team March 12, 2022 16:29
@crobibero crobibero removed this from Active PRs in Release 10.8.0 Mar 19, 2022
@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Mar 25, 2022
@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Oct 7, 2022
@Bond-009 Bond-009 merged commit 2e4db18 into jellyfin:master Oct 7, 2022
@kooolarpan
Copy link
Contributor

Finally, it's done. 👍

@1337joe 1337joe mentioned this pull request Oct 7, 2022
Merged
@1337joe 1337joe deleted the add-hearing-impaired branch October 7, 2022 12:05
@crobibero crobibero added the release-highlight A major new feature for the next release label Oct 7, 2022
@systemcrash
Copy link

Shouldn't this update the docs also?

@cvium
Copy link
Member

cvium commented Oct 12, 2022

The docs are in a different repository, but yes the docs should probably be updated

@1337joe
Copy link
Member Author

1337joe commented Oct 14, 2022

Coming in jellyfin-archive/jellyfin-docs/pull/715

@sollermun
Copy link

This fix does not seem to work when the name of the files contains quality information, e.g. Movie Name (2020) WEBRip-1080p.en.hi.srt.

Jellyfin recognizes the subtitle as "en - Hindi - SUBRIP - External"

@Javex
Copy link

Javex commented Sep 21, 2023

@sollermun what version are you running? I came here because I had a similar issue and after some searching found out that the latest release (10.8.10) does not include the feature yet. I then tested the issue against the current master and there it worked as described. If you're running 10.8.x instead of the latest nightly/unstable build, that might be the reason and we'll have to wait for 10.9 to be released.

@1337joe 1337joe mentioned this pull request Nov 28, 2023
Closed
1 task
@nielsvanvelzen nielsvanvelzen mentioned this pull request Mar 20, 2024
Closed
@VampiricAlien VampiricAlien mentioned this pull request Mar 23, 2024
Open
@mikewesten
Copy link

mikewesten commented May 14, 2024 •
edited

.

@thornbill
Copy link
Member

@mikewesten please open an issue instead of commenting on an old PR

@mikewesten mikewesten mentioned this pull request Jun 7, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvium cvium cvium approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

Assignees
No one assigned
Labels
release-highlight A major new feature for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identify external HI/CC/SDH subtitles