Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the int overflow issue and the wrong map index of external audio #7941

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

nyanmisaka
Copy link
Member

@nyanmisaka nyanmisaka commented Jun 15, 2022

Changes

  • Fix the int overflow issue in encoder bufsize,
    cap the max target bitrate to int.MaxValue/2 = 1073741823, which is more than enough for any common videos.
  • Fix the map index of external audio

Issues
Fixes jellyfin/jellyfin-plugin-tvheadend#59
FIxes #7942

@nyanmisaka nyanmisaka added the stable backport Backport into the next stable release label Jun 15, 2022
@github-actions
Copy link

github-actions bot commented Jun 15, 2022

No changes to OpenAPI specification found. See history of this comment for previous changes.

Copy link
Member

@cvium cvium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't hurt to add a code comment regarding Max / 2

@articuno1au
Copy link

Thanks for the quick turn around on this one 👏

@nyanmisaka nyanmisaka changed the title Fix the int overflow issue in encoder bufsize Fix the int overflow issue and the wrong map index of external audio Jun 15, 2022
@crobibero crobibero merged commit fd4ffc6 into release-10.8.z Jun 15, 2022
@crobibero crobibero deleted the fix-overflow branch June 15, 2022 21:27
jellyfin-bot pushed a commit that referenced this pull request Jun 29, 2022
(cherry picked from commit fd4ffc6)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants