Add VideoRangeType to video conditions #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanmisaka
force-pushed
the
video-range-condition
branch
from
3e01e73
to
9eb4d92
Compare
This is used to distinguish whether the client supports specific VideoRangeType, such as SDR, HDR10, HLG and DOVI. Usage is similar to Video Profile condition.
nyanmisaka
force-pushed
the
video-range-condition
branch
from
9eb4d92
to
be72001
Compare
crobibero
reviewed
Jun 16, 2022
Co-authored-by: Cody Robibero <cody@robibe.ro>
nyanmisaka
force-pushed
the
video-range-condition
branch
from
fdca6aa
to
477b922
Compare
crobibero
approved these changes
Jun 16, 2022
cvium
reviewed
Jun 17, 2022
cvium
approved these changes
Jun 17, 2022
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
jellyfin-bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
(cherry picked from commit f1d56aa) Signed-off-by: Joshua Boniface <joshua@boniface.me>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to distinguish whether the client supports specific VideoRangeType, such as SDR, HDR10, HLG and DOVI.
Since it's basically a copy-paste from the Video Profile condition, usages are similar.
@dmitrylyzo has tried to add the "IsHdr" condition in #7199, but I think that's isn't enough for various HDR types mentioned above.
With this PR, clients can declare supported video range types by querying device attributes. Server will follow the condition from clients to make a right decision between using Transcoding, DirectPlay, DirectStreaming or Remuxing.
Web
jellyfin/jellyfin-web#3713
Changes
Issues
Should fixes jellyfin/jellyfin-roku#552 if roku client implement this.