Fix subtitle encoder if subrip is requested #7960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would at least add it to the consts that already exist |
|
I thought about this too and didn't do it because technically srt and subrip are equivalent and having both of them in the enum would imply they aren't... |
|
Can you also take a look at the external ass/ssa subtitle? It doesn’t work for me either. |
crobibero
approved these changes
Jun 17, 2022
nyanmisaka
approved these changes
Jun 17, 2022
Pass-through should already be supported: I added barebone writers for SSA and ASS too, so in theory any text sub can be converted to both now if client requests it. |
crobibero
reviewed
Jun 18, 2022
Shadowghost
force-pushed
the
subrip-encoder-fix
branch
from
4f6f1ef
to
b60905f
Compare
Open
1 task
1 task
jellyfin-bot
pushed a commit
that referenced
this pull request
Jun 29, 2022
(cherry picked from commit ae79bbc) Signed-off-by: Joshua Boniface <joshua@boniface.me>
3 tasks
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Properly convert subtitles to subrip if requested.
Issues
Fixes #7958
Fixes jellyfin/Swiftfin#417