feat: make subtitleeditparser generic #8087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
Jul 24, 2022
…iguration loading
Bond-009
requested changes
Jul 30, 2022
Co-authored-by: Bond-009 <bond.009@outlook.com>
Co-authored-by: Bond-009 <bond.009@outlook.com>
Bond-009
requested changes
Aug 1, 2022
Co-authored-by: Bond-009 <bond.009@outlook.com>
Bond-009
approved these changes
Aug 1, 2022
jellyfin-bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
feat: make subtitleeditparser generic Authored-by: Claus Vium <cvium@users.noreply.github.com> Merged-by: Bond-009 <bond.009@outlook.com> Original-merge: 7323ccf
1 task
jellyfin-bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
After tagging v10.8.3, this can be restored to how it was and corrected as required in a separate PR. This reverts commit 494ed7e.
jellyfin-bot
pushed a commit
that referenced
this pull request
Aug 14, 2022
…parser"" This reverts commit 5bcab0f.
GiorgioBrux
pushed a commit
to GiorgioBrux/jellyfin
that referenced
this pull request
Sep 24, 2022
…8.z" This reverts commit 38eefbb.
1 task
Kakadus
pushed a commit
to Kakadus/jellyfin
that referenced
this pull request
Oct 2, 2022
feat: make subtitleeditparser generic Authored-by: Claus Vium <cvium@users.noreply.github.com> Merged-by: Bond-009 <bond.009@outlook.com> Original-merge: 7323ccf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Instead of hard coding and wrapping every
SubtitleFormatsub class, this introduces a generic parser that tries all availableSubtitleFormatbased on extension.Issues
Supercedes #8086