Extract external subs from container before determining characterset #8182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
Jul 28, 2022
Bond-009
approved these changes
Aug 2, 2022
jellyfin-bot
pushed a commit
that referenced
this pull request
Aug 14, 2022
Extract external subs from container before determining characterset Original-merge: 1faee43 Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Joshua Boniface <joshua@boniface.me>
Kakadus
pushed a commit
to Kakadus/jellyfin
that referenced
this pull request
Oct 2, 2022
Extract external subs from container before determining characterset Original-merge: 1faee43 Merged-by: Bond-009 <bond.009@outlook.com> Backported-by: Joshua Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtitle character set determination requires the subtitle to not be in a container. Timestamps should also not be reset to start at zero when extracting subtitles.
Changes
Fixes #8157