add taglib and imagemagick to sln #82
Conversation
There was a problem hiding this comment.
This was added earlier but broke the build in both the Docker image and my development environment (Arch Linux with dotnet-sdk==2.2.0+100-1).
Try testing your change by building it with in the Docker image.
docker build .
EDIT - I should mention that I have no clue what I'm doing with .NET dev. All I know is that the current Dockerfile builds and runs well for me.
|
Without this I get seventeen build errors instead of two build errors. ImageMagick isn't found at all and taglib throws the same error because the source built here is the same source I added to the main sln file. Still looking for the cause. |
|
The current SLN in master works fine for me in full visual studio IF you make sure you pull submodules as well. I wasn't having the hangup with imagemagick but I was with taglib and what was happening was git wasn't getting the submodules down right. Try git submodule update --init --recursive on the latest and see if you are ok afterwards |
|
Yeah I pulled the submodules, the exact error is below which made me think it might be a different issue. @nvllsvm what error did you get with the changes here?
|
|
I would try installing dotnet4.0 but I was under the impression only dotnetCore was required to build this project. |
|
I'll apaste it when I'm back on my workstation. For now, try building the Docker image. It's a portable environment that should replicate the problem I'm seeing. |
|
Just tried the docker image, it throws the same error I posted above using this patch. Unrelated but it looks like there isn't any mention of Since I can't currently build the project in my IDE before or after this change but the docker build only works before this change I am thinking that the docker config somehow includes dotnet4.0 in the build. |
|
They're in the sln file on master currenty ( Line 59 in f0c3789 I submitted a PR to add them a few hours ago since I had very similar problems to you (in Rider on MacOS). Everything is now working for me - @nvllsvm's changes removed a few of the build configurations for these projects (I think), which seemed to break the Docker build. Even after merging his changes, these projects are still part of the solution and building still works fine for me on MacOS. |
|
They're in the sln but they dont seem to be included in any of the build versions below, which I think is causing my issues. I am using the latest commit from master though so I don't think it's a |
|
Which platform are you on? |
|
Arch Linux, same as @nvllsvm. |
|
I'll try readding the removed build configs and getting docker build to work, they're not building on my workstation either.
…-------- Original Message --------
On 12 Dec 2018, 09:07, dkanada wrote:
Arch Linux, same as ***@***.***(https://github.com/nvllsvm).
—
You are receiving this because you commented.
Reply to this email directly, [view it on GitHub](#82 (comment)), or [mute the thread](https://github.com/notifications/unsubscribe-auth/ACbSNNuDL5R245-n-sJ3Z0SW-y_mGG9oks5u4MdGgaJpZM4ZOy5n).
|
|
According to this comment mono is also required to build taglib-sharp. I am not sure whether or not that dependency is open source, but I also don't see it in the build files, so I am wondering why the docker image works without mentioning mono. |
|
That's a good point, I also needed mono installed before everything started working. I wonder if we could split TagLibSharp and ImageMagickSharp out into nuget binary dependencies so that they didn't require building with the solution?
…-------- Original Message --------
On 12 Dec 2018, 09:47, dkanada wrote:
According to [this](mono/taglib-sharp#94 (comment)) comment mono is also required to build taglib-sharp. I am not sure whether or not that dependency is open source, but I also don't see it in the build files, so I am wondering why the docker image works without mentioning mono.
—
You are receiving this because you commented.
Reply to this email directly, [view it on GitHub](#82 (comment)), or [mute the thread](https://github.com/notifications/unsubscribe-auth/ACbSNFWWcH_hyLkn1_E_OnXXTgCpGzzSks5u4NCcgaJpZM4ZOy5n).
|
|
Before the full Jellyfin started I think I built everything using only dotnet core 2.1, no Mono was required. I wasn't rebuilding TagLib, though. @dkanada note that one of your errors seems to point to "netcore-app", not just "netcore". I'm not proficient with .net, but that looks strange. |
@dkanada can you take a look at your taglib-sharp.csproj? Mine has the following: |
|
@BnMcG publishing our own taglib-sharp nuget package doesn't seem like a good idea. The best solution (IMO) is waiting till someone at mono releases a new taglib-sharp nuget package, since the current one is from 2012. |
|
@Bond-009 Agreed if that's an option, there doesn't seem to be much movement on mono/taglib-sharp#40, though. |
|
@dkanada, Can you try pulling https://github.com/bnmcg/jellyfin/tree/build-thirdparty and building with this branch? I reverted this commit (so now ImageMagickSharp and TagLibSharp are both included in the sln and have build configurations), and now ImageMagickSharp and TagLibSharp build for me again. Is this also the case for you? @nvllsvm I've just tried docker build, and I think the 2 errors are where it's trying to build the .Net 4.5 version of taglibsharp and imagemagicksharp. I'll do some more digging when I get home, but I think at least on my workstation without docker, it builds the net standard libraries fine, and then fails on the net 4.5 versions. I'll see if we can just remove the .Net 4.5 target from both of these projects if everything now targets .net core/standard, or failing that see if we can specify which target to build against in the build command, rather than trying to build all targets (which seems to be what's happening at the moment). I think adding Mono to the Docker image would also fix the build issue, but that seems like a less optimal solution. |
|
@BnMcG nope I get the same error, which is weird because MonoDevelop recognizes my Mono installation. |
|
We should be aiming to remove aall Mono dependencies in favour of .NET Core if at all possible. |
|
I'll try ditching mono on my branch in the comment above and let you know how it goes.
…-------- Original Message --------
On 12 Dec 2018, 13:55, Joshua M. Boniface wrote:
We should be aiming to remove aall Mono dependencies in favour of .NET Core if at all possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#82 (comment)), or [mute the thread](https://github.com/notifications/unsubscribe-auth/ACbSNFRpJ5I-x6hKPBWw9Fpu-CRyAjyJks5u4QrggaJpZM4ZOy5n).
|
|
The easiest solution is to just remove the |
|
Not the same error message but this thread has a lot of people reporting issues using |
|
I am closing this to rebase on develop since pull requests go there now. |
Are these libraries supposed to be built at the moment? They weren't in the sln file. Also, the taglib submodule seems to throw an error that it only works with .NetFramework 4.0 and not Core on my machine.