Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more warnings #840

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
4 participants
@Bond-009
Copy link
Member

commented Feb 7, 2019

Fixes more warnings from the anayzers.

@nvllsvm

nvllsvm approved these changes Feb 8, 2019

@cvium

cvium approved these changes Feb 8, 2019

@@ -209,7 +209,7 @@ public void ValidateInput()
validate_form = true;
}

bool IsContentType(string ct, bool starts_with)
private bool IsContentType(string ct, bool starts_with)

This comment has been minimized.

Copy link
@cvium

cvium Feb 8, 2019

Member

Shouldn't arguments be camelcase?

@joshuaboniface joshuaboniface merged commit 387b4de into jellyfin:master Feb 9, 2019

2 checks passed

ci/dockercloud Your tests passed in Docker Cloud
Details
continuous-integration/drone/pr Build is passing
Details

@joshuaboniface joshuaboniface added this to In progress in 10.2.0 Release via automation Feb 9, 2019

@joshuaboniface joshuaboniface moved this from In progress to Reviewer approved in 10.2.0 Release Feb 9, 2019

@joshuaboniface joshuaboniface moved this from Reviewer approved to Done in 10.2.0 Release Feb 9, 2019

@Bond-009 Bond-009 deleted the Bond-009:requestcleanup branch Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.