Drop ETag and use Last-Modified header #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvium
requested review from
Bond-009 and
JustAMan
and removed request for
Bond-009
JustAMan
approved these changes
Feb 13, 2019
Bond-009
reviewed
Feb 13, 2019
It's just more code to maintain and more complex logic. If and when we have a more sensible http server I think it'll be more feasible. |
Bond-009
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Dropped ETag in favour of Last-Modified since it's very hard to determine proper file type without major changes. Computing ETags is just not very robust or useful in that case.
Issues
Fixes #873
Supercedes #886