Remove unused notification endpoints #8952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in OpenAPI specification found. Expand to see details.What's Deleted
|
crobibero
approved these changes
Dec 26, 2022
Shadowghost
approved these changes
Dec 27, 2022
Bond-009
approved these changes
Dec 27, 2022
1 task
nielsvanvelzen
added
the
enhancement
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove some unused notification endpoints. Most of them were no-op since forever (at least since the API migration). The only endpoint that actually did something was
CreateAdminNotificationbut I did not see any usages in any of our own clients.This PR focuses on the API, the notification manager could be cleaned a bit too because it does contain code to have user-targeted notifications which is not used.
Issues