Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi cleaning #8978

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Fix multi cleaning #8978

merged 1 commit into from
Dec 30, 2022

Conversation

Xavier-Do
Copy link
Contributor

Right now, a movie Name Iron Man Multi 1080p.mkv will be searched as Iron Man Multi leading to no result.

The cleaning regex was containing multi but it looks like a typo joined multi and subs in the same term.

Bond-009
Bond-009 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@Bond-009 Bond-009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a regression test for this?

@Xavier-Do
Copy link
Contributor Author

Can you add a regression test for this?

I can try (Just starting to code in JellyFin :) )

@PyXD
Fix multi cleaning
20580e9 
Right now, a movie Name `Iron Man Multi 1080p.mkv` will be searched as
`Iron
Man Multi` leading to no result.

The cleaning regex was containing multi but it looks like a typo joined
`multi` and `subs` in the same term.
@Xavier-Do
Copy link
Contributor Author

@Bond-009 Done, if it is ok for you :)

@crobibero crobibero merged commit 1f658f5 into jellyfin:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bond-009 Bond-009 Bond-009 approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Xavier-Do @Bond-009 @crobibero @PyXD