Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add additional entries if HEVC encoding is disabled #9092

Merged

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Jan 14, 2023

Changes
Don't add additional entries (for HEVC) if HEVC encoding is disabled.

Issues
Fixes #5576 (#5576 (comment))
Fixes #8043
Fixes jellyfin/jellyfin-webos#105
Fixes jellyfin/jellyfin-tizen#163

@nyanmisaka
Copy link
Member

The HEVC entries are also used for fMP4 remuxing.

@dmitrylyzo
Copy link
Contributor Author

dmitrylyzo commented Jan 14, 2023

The HEVC entries are also used for fMP4 remuxing.

Entries that require transcoding should not be added - they fallback to H264 and ruin your idea of autoselect.
We also need to fix the transcoding job (see #9016).
The second block doesn't seem to require transcoding though.

@Shadowghost Shadowghost added the stable backport Backport into the next stable release label Jan 14, 2023
@crobibero crobibero merged commit 2a5efeb into jellyfin:release-10.8.z Jan 14, 2023
@dmitrylyzo dmitrylyzo deleted the no-hevc-no-extra-entry branch January 15, 2023 20:09
jellyfin-bot pushed a commit that referenced this pull request Jan 22, 2023
Don't add additional entries if HEVC encoding is disabled

Original-merge: 2a5efeb

Merged-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants