Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplicationHost cleanup #9191

Merged
merged 6 commits into from
Feb 2, 2023
Merged

ApplicationHost cleanup #9191

merged 6 commits into from
Feb 2, 2023

Conversation

barronpm
Copy link
Member

@barronpm barronpm commented Jan 28, 2023 •
edited

Changes

  • Move LogEnvironmentInfo to StartupHelpers
  • Use DI for IChannel and ISubtitleProvider
  • Minor cleanup

@barronpm barronpm added needs testing breaking change: plugin api Includes a breaking change for the plugin API labels Jan 28, 2023
crobibero
crobibero approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@crobibero crobibero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change plugins will need to manually register the following services

IChannel

  • jellyfin/jellyfin-plugin-nextpvr
  • jellyfin/jellyfin-plugin-tvheadend

ISubtitleProvider

  • jellyfin/jellyfin-plugin-opensubtitles

@crobibero crobibero merged commit 58b3945 into jellyfin:master Feb 2, 2023
@barronpm barronpm deleted the applicationhost-cleanup1 branch February 2, 2023 14:38
@MBR-0001 MBR-0001 mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowghost Shadowghost Shadowghost approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
breaking change: plugin api Includes a breaking change for the plugin API needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@barronpm @Shadowghost @Bond-009 @crobibero